Commit fa6114d4 authored Oct 07, 2016 by Nathan Sullivan Committed by David S. Miller Oct 07, 2016

net: macb: NULL out phydev after removing mdio bus



To ensure the dev->phydev pointer is not used after becoming invalid in
mdiobus_unregister, set it to NULL. This happens when removing the macb
driver without first taking its interface down, since unregister_netdev
will end up calling macb_close.

Signed-off-by: Xander Huff <xander.huff@ni.com>
Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
Signed-off-by: Brad Mouring <brad.mouring@ni.com>
Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 912e27e8

drivers/net/ethernet/cadence/macb.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -3117,6 +3117,7 @@ static int macb_remove(struct platform_device *pdev)
		if (dev->phydev)
		phy_disconnect(dev->phydev);
		mdiobus_unregister(bp->mii_bus);
		dev->phydev = NULL;
		mdiobus_free(bp->mii_bus);

		/* Shutdown the PHY if there is a GPIO reset */