Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa4144b7 authored by Al Viro's avatar Al Viro Committed by Linus Torvalds
Browse files

cdc-wdm endianness fixes 



* wMaxPacketSize is le16; copying it to a field of local structure and then
  using that field as host-endian (size of object to be allocated) is broken.
* bMaxPacketSize0 is 8-bit; feeding it to le16_to_cpu() is bogus and since the
  result is used as host-endian, it's not even misspelled cpu_to_le16().

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 76e6f252

drivers/usb/class/cdc-wdm.c

+2 −2
Original line number Diff line number Diff line
@@ -611,8 +611,8 @@ static int wdm_probe(struct usb_interface *intf, const struct usb_device_id *id) 
		goto err;

	}



	desc->wMaxPacketSize = ep->wMaxPacketSize;

	desc->bMaxPacketSize0 = cpu_to_le16(udev->descriptor.bMaxPacketSize0);

	desc->wMaxPacketSize = le16_to_cpu(ep->wMaxPacketSize);

	desc->bMaxPacketSize0 = udev->descriptor.bMaxPacketSize0;



	desc->orq = kmalloc(sizeof(struct usb_ctrlrequest), GFP_KERNEL);

	if (!desc->orq)