Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa25b99a authored by Denys Vlasenko's avatar Denys Vlasenko Committed by James Bottomley
Browse files

[SCSI] aic7xxx: introduce "dont_generate_debug_code" keyword in aicasm parser 



aic7xxx still contains ~30kb of dead code if pretty printing of registers
is requested. These patches deal with it.

Size differences:

   text    data     bss     dec     hex filename
DEBUG_ENABLE+PRETTY_PRINT:
 234697    2362    1188  238247   3a2a7 linux-2.6.26-rc8-/drivers/scsi/aic7xxx/built-in.o
 205092    2362    1188  208642   32f02 linux-2.6.26-rc8/drivers/scsi/aic7xxx/built-in.o
NO_DEBUG_ENABLE+PRETTY_PRINT:
 227272    2362    1172  230806   38596 linux-2.6.26-rc8-/drivers/scsi/aic7xxx/built-in.o
 197671    2362    1172  201205   311f5 linux-2.6.26-rc8/drivers/scsi/aic7xxx/built-in.o
DEBUG_ENABLE+NO_PRETTY_PRINT:
 192457    2362    1188  196007   2fda7 linux-2.6.26-rc8-/drivers/scsi/aic7xxx/built-in.o
 192457    2362    1188  196007   2fda7 linux-2.6.26-rc8/drivers/scsi/aic7xxx/built-in.o
NO_DEBUG_ENABLE+NO_PRETTY_PRINT:
 185040    2362    1172  188574   2e09e linux-2.6.26-rc8-/drivers/scsi/aic7xxx/built-in.o
 185040    2362    1172  188574   2e09e linux-2.6.26-rc8/drivers/scsi/aic7xxx/built-in.o

This patch:

Introduce "dont_generate_debug_code" keyword in aicasm parser.

Signed-off-by: default avatarDenys Vlasenko <vda.linux@googlemail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Acked-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent 5a36756b

drivers/scsi/aic7xxx/aicasm/aicasm_gram.y

+10 −0
Original line number Diff line number Diff line
@@ -147,6 +147,8 @@ void yyerror(const char *string); 


%token T_ACCESS_MODE



%token T_DONT_GENERATE_DEBUG_CODE



%token T_MODES



%token T_DEFINE
@@ -357,6 +359,7 @@ reg_attribute: 
|	size

|	count

|	access_mode

|	dont_generate_debug_code

|	modes

|	field_defn

|	enum_defn
@@ -410,6 +413,13 @@ access_mode: 
	}

;



dont_generate_debug_code:

	T_DONT_GENERATE_DEBUG_CODE

	{

		cur_symbol->dont_generate_debug_code = 1;

	}

;



modes:

	T_MODES mode_list

	{

drivers/scsi/aic7xxx/aicasm/aicasm_scan.l

+1 −0
Original line number Diff line number Diff line
@@ -164,6 +164,7 @@ download { return T_DOWNLOAD; } 
address			{ return T_ADDRESS; }

count			{ return T_COUNT; }

access_mode		{ return T_ACCESS_MODE; }

dont_generate_debug_code { return T_DONT_GENERATE_DEBUG_CODE; }

modes			{ return T_MODES; }

RW|RO|WO		{

				 if (strcmp(yytext, "RW") == 0)

drivers/scsi/aic7xxx/aicasm/aicasm_symbol.c

+3 −0
Original line number Diff line number Diff line
@@ -539,6 +539,9 @@ symtable_dump(FILE *ofile, FILE *dfile) 
	aic_print_include(dfile, stock_include_file);

	SLIST_FOREACH(curnode, &registers, links) {



		if (curnode->symbol->dont_generate_debug_code)

			continue;



		switch(curnode->symbol->type) {

		case REGISTER:

		case SCBLOC:

drivers/scsi/aic7xxx/aicasm/aicasm_symbol.h

+2 −1
Original line number Diff line number Diff line
@@ -138,6 +138,7 @@ typedef struct symbol { 
		struct cond_info  *condinfo;

		struct macro_info *macroinfo;

	} info;

	int	dont_generate_debug_code;

} symbol_t;



typedef struct symbol_ref {