Commit f9dd0ce6 authored Sep 09, 2014 by Dan Carpenter Committed by Bjorn Helgaas Sep 16, 2014

PCI: xilinx: Fix xilinx_pcie_assign_msi() return value test



We should be testing "hwirq" instead of "irq".  "irq" is unsigned so it's
never less than zero.  Also it's uninitialized.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Srikanth Thokala <sthokal@xilinx.com>

parent 8961def5

drivers/pci/host/pcie-xilinx.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -359,8 +359,8 @@ static int xilinx_pcie_msi_setup_irq(struct msi_chip *chip,
		phys_addr_t msg_addr;

		hwirq = xilinx_pcie_assign_msi(port);
		if (irq < 0)
		return irq;
		if (hwirq < 0)
		return hwirq;

		irq = irq_create_mapping(port->irq_domain, hwirq);
		if (!irq)