Commit f9d42491 authored Apr 25, 2008 by Roel Kluin Committed by Jeff Garzik Apr 25, 2008

pata_bf54x: decrease count first.



When count reaches 0 the postfix decrement still subtracts (to -1),
so bfin_reset_controller() returns as if the busy flag was cleared
while it was not.

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Acked-by: Sonic Zhang <sonic.zhang@analog.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

parent 85afb934

drivers/ata/pata_bf54x.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1417,7 +1417,7 @@ static int bfin_reset_controller(struct ata_host *host)
		count = 10000000;
		do {
		status = read_atapi_register(base, ATA_REG_STATUS);
		} while (count-- && (status & ATA_BUSY));
		} while (--count && (status & ATA_BUSY));

		/* Enable only ATAPI Device interrupt */
		ATAPI_SET_INT_MASK(base, 1);