Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f99d3308 authored by Benjamin Romer's avatar Benjamin Romer Committed by Greg Kroah-Hartman
Browse files

staging: unisys: cleanup rc -1 in create_visor_device() 



Get rid of the rc = -1 initialization. Return a meaningful error on
failure in the function, or, the rc from a called function if it fails.

Signed-off-by: default avatarBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f748f64f

drivers/staging/unisys/visorbus/visorbus_main.c

+5 −3
Original line number Diff line number Diff line
@@ -973,7 +973,7 @@ EXPORT_SYMBOL_GPL(visorbus_disable_channel_interrupts); 
static int

create_visor_device(struct visor_device *dev)

{

	int rc = -1;

	int rc;

	u32 chipset_bus_no = dev->chipset_bus_no;

	u32 chipset_dev_no = dev->chipset_dev_no;
@@ -995,6 +995,7 @@ create_visor_device(struct visor_device *dev) 
	if (!dev->periodic_work) {

		POSTCODE_LINUX_3(DEVICE_CREATE_FAILURE_PC, chipset_dev_no,

				 DIAG_SEVERITY_ERR);

		rc = -EINVAL;

		goto away;

	}
@@ -1032,14 +1033,15 @@ create_visor_device(struct visor_device *dev) 
	if (rc < 0) {

		POSTCODE_LINUX_3(DEVICE_REGISTER_FAILURE_PC, chipset_dev_no,

				 DIAG_SEVERITY_ERR);

		goto away_register;

		goto away_unregister;

	}



	list_add_tail(&dev->list_all, &list_all_device_instances);

	return 0;



away_register:

away_unregister:

	device_unregister(&dev->device);



away:

	put_device(&dev->device);

	return rc;