Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f991a65c authored by Roel Kluin's avatar Roel Kluin Committed by Greg Kroah-Hartman
Browse files

staging: rtlxxxx: off by one in AsicSendCommandToMcu() and NDIS_STATUS NICLoadFirmware() 



With a postfix increment i/Index is incremented beyond 100/1000 so the
message will be displayed too soon.

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 8d72f98a

drivers/staging/rt2860/common/mlme.c

+1 −1
Original line number Diff line number Diff line
@@ -7866,7 +7866,7 @@ BOOLEAN AsicSendCommandToMcu( 
		RTMPusecDelay(2);

	} while(i++ < 100);



	if (i >= 100)

	if (i > 100)

	{

		{

#ifdef RT2860

drivers/staging/rt2860/common/rtmp_init.c

+1 −1
Original line number Diff line number Diff line
@@ -3366,7 +3366,7 @@ NDIS_STATUS NICLoadFirmware( 
		RTMPusecDelay(1000);

	} while (Index++ < 1000);



    if (Index >= 1000)

    if (Index > 1000)

	{

		Status = NDIS_STATUS_FAILURE;

		DBGPRINT(RT_DEBUG_ERROR, ("NICLoadFirmware: MCU is not ready\n\n\n"));