Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f97c2309 authored by Hongzhou Yang's avatar Hongzhou Yang Committed by Linus Walleij
Browse files

pinctrl: mediatek: Add get_direction support. 



Since Linux gpio framework return 0 for output, 1 for input.
But HW use 0 stands for input, and 1 stands for output.
So use negative to correct it.

And gpio_chip.get is used to get input value, no need to get
output value, so removing it.

Signed-off-by: default avatarHongzhou Yang <hongzhou.yang@mediatek.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent c3dd25cc

drivers/pinctrl/mediatek/pinctrl-mtk-common.c

+4 −7
Original line number Diff line number Diff line
@@ -747,7 +747,7 @@ static int mtk_gpio_get_direction(struct gpio_chip *chip, unsigned offset) 
	reg_addr =  mtk_get_port(pctl, offset) + pctl->devdata->dir_offset;

	bit = BIT(offset & 0xf);

	regmap_read(pctl->regmap1, reg_addr, &read_val);

	return !!(read_val & bit);

	return !(read_val & bit);

}



static int mtk_gpio_get(struct gpio_chip *chip, unsigned offset)
@@ -757,10 +757,6 @@ static int mtk_gpio_get(struct gpio_chip *chip, unsigned offset) 
	unsigned int read_val = 0;

	struct mtk_pinctrl *pctl = dev_get_drvdata(chip->dev);



	if (mtk_gpio_get_direction(chip, offset))

		reg_addr = mtk_get_port(pctl, offset) +

			pctl->devdata->dout_offset;

	else

	reg_addr = mtk_get_port(pctl, offset) +

		pctl->devdata->din_offset;
@@ -997,6 +993,7 @@ static struct gpio_chip mtk_gpio_chip = { 
	.owner			= THIS_MODULE,

	.request		= gpiochip_generic_request,

	.free			= gpiochip_generic_free,

	.get_direction		= mtk_gpio_get_direction,

	.direction_input	= mtk_gpio_direction_input,

	.direction_output	= mtk_gpio_direction_output,

	.get			= mtk_gpio_get,