Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f8a22a2b authored by Dan Carpenter's avatar Dan Carpenter Committed by John W. Linville
Browse files

iwlwifi: missing unlock on error path 



We should unlock here instead of returning -EINVAL directly.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 9011cd25

drivers/net/wireless/iwlwifi/iwl-agn.c

+5 −2
Original line number Diff line number Diff line
@@ -3009,14 +3009,17 @@ static int iwl_mac_offchannel_tx_cancel_wait(struct ieee80211_hw *hw) 


	mutex_lock(&priv->mutex);



	if (!priv->_agn.offchan_tx_skb)

		return -EINVAL;

	if (!priv->_agn.offchan_tx_skb) {

		ret = -EINVAL;

		goto unlock;

	}



	priv->_agn.offchan_tx_skb = NULL;



	ret = iwl_scan_cancel_timeout(priv, 200);

	if (ret)

		ret = -EIO;

unlock:

	mutex_unlock(&priv->mutex);



	return ret;