Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f86ce0ad authored by Martin Hundebøll's avatar Martin Hundebøll Committed by Antonio Quartulli
Browse files

batman-adv: Return reason for failure in batadv_check_unicast_packet() 



batadv_check_unicast_packet() is changed to return a value based on the
reason to drop the packet, which will be useful information for
future users of batadv_check_unicast_packet().

Signed-off-by: default avatarMartin Hundebøll <martin@hundeboll.net>
Acked-by: default avatarAntonio Quartulli <ordex@autistici.org>
Signed-off-by: default avatarMarek Lindner <lindner_marek@yahoo.de>
Signed-off-by: default avatarAntonio Quartulli <ordex@autistici.org>
parent 736292c2

net/batman-adv/routing.c

+14 −4
Original line number Diff line number Diff line
@@ -548,27 +548,37 @@ batadv_find_ifalter_router(struct batadv_orig_node *primary_orig, 
	return router;

}



/**

 * batadv_check_unicast_packet - Check for malformed unicast packets

 * @skb: packet to check

 * @hdr_size: size of header to pull

 *

 * Check for short header and bad addresses in given packet. Returns negative

 * value when check fails and 0 otherwise. The negative value depends on the

 * reason: -ENODATA for bad header, -EBADR for broadcast destination or source,

 * and -EREMOTE for non-local (other host) destination.

 */

static int batadv_check_unicast_packet(struct sk_buff *skb, int hdr_size)

{

	struct ethhdr *ethhdr;



	/* drop packet if it has not necessary minimum size */

	if (unlikely(!pskb_may_pull(skb, hdr_size)))

		return -1;

		return -ENODATA;



	ethhdr = (struct ethhdr *)skb_mac_header(skb);



	/* packet with unicast indication but broadcast recipient */

	if (is_broadcast_ether_addr(ethhdr->h_dest))

		return -1;

		return -EBADR;



	/* packet with broadcast sender address */

	if (is_broadcast_ether_addr(ethhdr->h_source))

		return -1;

		return -EBADR;



	/* not for me */

	if (!batadv_is_my_mac(ethhdr->h_dest))

		return -1;

		return -EREMOTE;



	return 0;

}