Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f8246f31 authored by Alex Chiang's avatar Alex Chiang Committed by Linus Torvalds
Browse files

mm: refactor register_cpu_under_node() 



By returning early if the node is not online, we can unindent the
interesting code by one level.

No functional change.

Signed-off-by: default avatarAlex Chiang <achiang@hp.com>
Cc: Gary Hade <garyhade@us.ibm.com>
Cc: Badari Pulavarty <pbadari@us.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: David Rientjes <rientjes@google.com>
Cc: Greg KH <greg@kroah.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Cc: David Rientjes <rientjes@google.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent dee5d0d5

drivers/base/node.c

+11 −9
Original line number Original line Diff line number Diff line
@@ -271,18 +271,20 @@ struct node node_devices[MAX_NUMNODES]; 
 */

 */

int register_cpu_under_node(unsigned int cpu, unsigned int nid)

int register_cpu_under_node(unsigned int cpu, unsigned int nid)

{

{

	if (node_online(nid)) {

	struct sys_device *obj;

		struct sys_device *obj = get_cpu_sysdev(cpu);



	if (!node_online(nid))

		return 0;



	obj = get_cpu_sysdev(cpu);

	if (!obj)

	if (!obj)

		return 0;

		return 0;



	return sysfs_create_link(&node_devices[nid].sysdev.kobj,

	return sysfs_create_link(&node_devices[nid].sysdev.kobj,

				&obj->kobj,

				&obj->kobj,

				kobject_name(&obj->kobj));

				kobject_name(&obj->kobj));

}

}





	return 0;

}



int unregister_cpu_under_node(unsigned int cpu, unsigned int nid)

int unregister_cpu_under_node(unsigned int cpu, unsigned int nid)

{

{

	if (node_online(nid)) {

	if (node_online(nid)) {