Commit f7cf4f5b authored Apr 03, 2014 by alex chen Committed by Linus Torvalds Apr 03, 2014

ocfs2: do not put bh when buffer_uptodate failed



Do not put bh when buffer_uptodate failed in ocfs2_write_block and
ocfs2_write_super_or_backup, because it will put bh in b_end_io.
Otherwise it will hit a warning "VFS: brelse: Trying to free free
buffer".

Signed-off-by: Alex Chen <alex.chen@huawei.com>
Reviewed-by: Joseph Qi <joseph.qi@huawei.com>
Reviewed-by: Srinivas Eeda <srinivas.eeda@oracle.com>
Cc: Mark Fasheh <mfasheh@suse.com>
Acked-by: Joel Becker <jlbec@evilplan.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 466e68c4

fs/ocfs2/buffer_head_io.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -90,7 +90,6 @@ int ocfs2_write_block(struct ocfs2_super osb, struct buffer_head bh,
		* information for this bh as it's not marked locally
		* uptodate. */
		ret = -EIO;
		put_bh(bh);
		mlog_errno(ret);
		}

		@@ -420,7 +419,6 @@ int ocfs2_write_super_or_backup(struct ocfs2_super *osb,

		if (!buffer_uptodate(bh)) {
		ret = -EIO;
		put_bh(bh);
		mlog_errno(ret);
		}