Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f78d98f6 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: warn on logging functions with KERN_<LEVEL> 



Warn on probable misuses of logging functions with KERN_<LEVEL>
like pr_err(KERN_ERR "foo\n");

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Suggested-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 840080a0

scripts/checkpatch.pl

+11 −0
Original line number Diff line number Diff line
@@ -4447,6 +4447,17 @@ sub process { 
			}

		}



# check for logging functions with KERN_<LEVEL>

		if ($line !~ /printk\s*\(/ &&

		    $line =~ /\b$logFunctions\s*\(.*\b(KERN_[A-Z]+)\b/) {

			my $level = $1;

			if (WARN("UNNECESSARY_KERN_LEVEL",

				 "Possible unnecessary $level\n" . $herecurr) &&

			    $fix) {

				$fixed[$fixlinenr] =~ s/\s*$level\s*//;

			}

		}



# check for bad placement of section $InitAttribute (e.g.: __initdata)

		if ($line =~ /(\b$InitAttribute\b)/) {

			my $attr = $1;