Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f73ec48c authored by Alexander Shishkin's avatar Alexander Shishkin Committed by Ingo Molnar
Browse files

perf/x86/intel/pt: Untangle pt_buffer_reset_markers() 



Currently, pt_buffer_reset_markers() is a difficult to read knot of
arithmetics with a redundant check for multiple-entry TOPA capability,
a commented out wakeup marker placement and a logical error wrt to
stop marker placement. The latter happens when write head is not page
aligned and results in stop marker being placed one page earlier than
it actually should.

All these problems only affect PT implementations that support
multiple-entry TOPA tables (read: proper scatter-gather).

For single-entry TOPA implementations, there is no functional impact.

This patch deals with all of the above. Tested on both single-entry
and multiple-entry TOPA PT implementations.

Signed-off-by: default avatarAlexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: acme@infradead.org
Cc: adrian.hunter@intel.com
Cc: hpa@zytor.com
Link: http://lkml.kernel.org/r/1432308626-18845-4-git-send-email-alexander.shishkin@linux.intel.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent aa319bcd

arch/x86/kernel/cpu/perf_event_intel_pt.c

+22 −12
Original line number Diff line number Diff line
@@ -615,7 +615,8 @@ static int pt_buffer_reset_markers(struct pt_buffer *buf, 
				   struct perf_output_handle *handle)



{

	unsigned long idx, npages, end;

	unsigned long head = local64_read(&buf->head);

	unsigned long idx, npages, wakeup;



	if (buf->snapshot)

		return 0;
@@ -634,17 +635,26 @@ static int pt_buffer_reset_markers(struct pt_buffer *buf, 
	buf->topa_index[buf->stop_pos]->stop = 0;

	buf->topa_index[buf->intr_pos]->intr = 0;



	if (pt_cap_get(PT_CAP_topa_multiple_entries)) {

		npages = (handle->size + 1) >> PAGE_SHIFT;

		end = (local64_read(&buf->head) >> PAGE_SHIFT) + npages;

		/*if (end > handle->wakeup >> PAGE_SHIFT)

		  end = handle->wakeup >> PAGE_SHIFT;*/

		idx = end & (buf->nr_pages - 1);

	/* how many pages till the STOP marker */

	npages = handle->size >> PAGE_SHIFT;



	/* if it's on a page boundary, fill up one more page */

	if (!offset_in_page(head + handle->size + 1))

		npages++;



	idx = (head >> PAGE_SHIFT) + npages;

	idx &= buf->nr_pages - 1;

	buf->stop_pos = idx;

		idx = (local64_read(&buf->head) >> PAGE_SHIFT) + npages - 1;



	wakeup = handle->wakeup >> PAGE_SHIFT;



	/* in the worst case, wake up the consumer one page before hard stop */

	idx = (head >> PAGE_SHIFT) + npages - 1;

	if (idx > wakeup)

		idx = wakeup;



	idx &= buf->nr_pages - 1;

	buf->intr_pos = idx;

	}



	buf->topa_index[buf->stop_pos]->stop = 1;

	buf->topa_index[buf->intr_pos]->intr = 1;