Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f72d19f0 authored by Paulo Zanoni's avatar Paulo Zanoni Committed by Daniel Vetter
Browse files

drm/i915: silence useless messages about DDI buffer translation 



These messages are not really useful since it's very easy to check
which mode is used for each port: The values programmed are based on
the port type, then assigned to the ddi_translations variable.
Currently we use DP mode for ports A-D and FDI mode for port E.

Also, when we add the code to enable/disable PC8+,
intel_prepare_ddi_buffers will be called more often and will eat your
dmesg buffers.

While at it, fix the coding style of the "for" statement above.

Signed-off-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
[danvet: Pimp commit message with Paulo's more detailed explanation of
how the ddi translation buffer settings are computed, to answer a
question from Chris.]
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 637efacf

drivers/gpu/drm/i915/intel_ddi.c

+2 −9
Original line number Diff line number Diff line
@@ -94,15 +94,8 @@ static void intel_prepare_ddi_buffers(struct drm_device *dev, enum port port, 
		hsw_ddi_translations_fdi :

		hsw_ddi_translations_dp);



	DRM_DEBUG_DRIVER("Initializing DDI buffers for port %c in %s mode\n",

			port_name(port),

			use_fdi_mode ? "FDI" : "DP");



	WARN((use_fdi_mode && (port != PORT_E)),

		"Programming port %c in FDI mode, this probably will not work.\n",

		port_name(port));



	for (i=0, reg=DDI_BUF_TRANS(port); i < ARRAY_SIZE(hsw_ddi_translations_fdi); i++) {

	for (i = 0, reg = DDI_BUF_TRANS(port);

	     i < ARRAY_SIZE(hsw_ddi_translations_fdi); i++) {

		I915_WRITE(reg, ddi_translations[i]);

		reg += 4;

	}