Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f5b9cc6a authored by Laurent Pinchart's avatar Laurent Pinchart
Browse files

intelfb: use display information in info not in var for panning 



We must not use any information in the passed var besides xoffset,
yoffset and vmode as otherwise applications might abuse it.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
parent 09a9168d

drivers/video/intelfb/intelfbhw.c

+3 −3
Original line number Diff line number Diff line
@@ -390,12 +390,12 @@ int intelfbhw_pan_display(struct fb_var_screeninfo *var, struct fb_info *info) 
	xoffset = ROUND_DOWN_TO(var->xoffset, 8);

	yoffset = var->yoffset;



	if ((xoffset + var->xres > var->xres_virtual) ||

	    (yoffset + var->yres > var->yres_virtual))

	if ((xoffset + info->var.xres > info->var.xres_virtual) ||

	    (yoffset + info->var.yres > info->var.yres_virtual))

		return -EINVAL;



	offset = (yoffset * dinfo->pitch) +

		 (xoffset * var->bits_per_pixel) / 8;

		 (xoffset * info->var.bits_per_pixel) / 8;



	offset += dinfo->fb.offset << 12;