Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f58518e6 authored by Ilpo Järvinen's avatar Ilpo Järvinen Committed by David S. Miller
Browse files

[NET]: uninline dev_alloc_skb, de-bloats a lot 



Allyesconfig (v2.6.24-mm1):

-23668  392 funcs, 104 +, 23772 -, diff: -23668 --- dev_alloc_skb

Without many debug CONFIGs (v2.6.25-rc2-mm1):

-12178  382 funcs, 157 +, 12335 -, diff: -12178 --- dev_alloc_skb
dev_alloc_skb                 |  +37

Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6be8ac2f

include/linux/skbuff.h

+1 −16
Original line number Diff line number Diff line
@@ -1272,22 +1272,7 @@ static inline struct sk_buff *__dev_alloc_skb(unsigned int length, 
	return skb;

}



/**

 *	dev_alloc_skb - allocate an skbuff for receiving

 *	@length: length to allocate

 *

 *	Allocate a new &sk_buff and assign it a usage count of one. The

 *	buffer has unspecified headroom built in. Users should allocate

 *	the headroom they think they need without accounting for the

 *	built in space. The built in space is used for optimisations.

 *

 *	%NULL is returned if there is no free memory. Although this function

 *	allocates memory it can be called from an interrupt.

 */

static inline struct sk_buff *dev_alloc_skb(unsigned int length)

{

	return __dev_alloc_skb(length, GFP_ATOMIC);

}

extern struct sk_buff *dev_alloc_skb(unsigned int length);



extern struct sk_buff *__netdev_alloc_skb(struct net_device *dev,

		unsigned int length, gfp_t gfp_mask);

net/core/skbuff.c

+18 −0
Original line number Diff line number Diff line
@@ -263,6 +263,24 @@ struct sk_buff *__netdev_alloc_skb(struct net_device *dev, 
	return skb;

}



/**

 *	dev_alloc_skb - allocate an skbuff for receiving

 *	@length: length to allocate

 *

 *	Allocate a new &sk_buff and assign it a usage count of one. The

 *	buffer has unspecified headroom built in. Users should allocate

 *	the headroom they think they need without accounting for the

 *	built in space. The built in space is used for optimisations.

 *

 *	%NULL is returned if there is no free memory. Although this function

 *	allocates memory it can be called from an interrupt.

 */

struct sk_buff *dev_alloc_skb(unsigned int length)

{

	return __dev_alloc_skb(length, GFP_ATOMIC);

}

EXPORT_SYMBOL(dev_alloc_skb);



static void skb_drop_list(struct sk_buff **listp)

{

	struct sk_buff *list = *listp;