Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f5776941 authored by David S. Miller's avatar David S. Miller
Browse files

nf_conntrack_proto_generic: Stop using NLA_PUT*(). 



These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 242ddfc0

net/netfilter/nf_conntrack_proto_generic.c

+2 −1
Original line number Diff line number Diff line
@@ -90,7 +90,8 @@ generic_timeout_obj_to_nlattr(struct sk_buff *skb, const void *data) 
{

	const unsigned int *timeout = data;



	NLA_PUT_BE32(skb, CTA_TIMEOUT_GENERIC_TIMEOUT, htonl(*timeout / HZ));

	if (nla_put_be32(skb, CTA_TIMEOUT_GENERIC_TIMEOUT, htonl(*timeout / HZ)))

		goto nla_put_failure;



	return 0;