Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f417f5e4 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

isdn: cleanup: make buffer smaller 



This showed up in my audit because we use strcpy() to copy "ds" into a
32 character buffer inside the isdn_tty_dial() function.  But it turns
out that we only ever use the first 32 characters so it's OK.  I have
changed the declaration to make the static checkers happy.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 017d79ef

drivers/isdn/i4l/isdn_tty.c

+2 −2
Original line number Diff line number Diff line
@@ -3515,7 +3515,7 @@ isdn_tty_parse_at(modem_info * info) 
{

	atemu *m = &info->emu;

	char *p;

	char ds[40];

	char ds[ISDN_MSNLEN];



#ifdef ISDN_DEBUG_AT

	printk(KERN_DEBUG "AT: '%s'\n", m->mdmcmd);
@@ -3594,7 +3594,7 @@ isdn_tty_parse_at(modem_info * info) 
						break;

					case '3':

                                                p++;

                                                sprintf(ds, "\r\n%d", info->emu.charge);

                                                snprintf(ds, sizeof(ds), "\r\n%d", info->emu.charge);

                                                isdn_tty_at_cout(ds, info);

                                                break;

					default:;