Commit f3f128d4 authored Jul 02, 2014 by Lendacky, Thomas Committed by David S. Miller Jul 07, 2014

amd-xgbe: Fix debugfs compatibility change with kstrtouint



The initial change from sscanf to kstrtouint broke backward
compatbility by using a base of "0" in the kstrtouint call.
This allowed for entering decimal, hexadecimal or octal as
input where previously the sscanf always interpreted the input
as hexadecimal.  Additionally, -EIO was returned on error prior
to this change and now it is whatever the error value that is
returned by kstrtouint.

Change the base value of the kstrtouint from 0 to 16 and return
-EIO on error.

Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Reported-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent db55b62c

drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -165,9 +165,9 @@ static ssize_t xgbe_common_write(const char __user *buffer, size_t count,
		return len;

		workarea[len] = '\0';
		ret = kstrtouint(workarea, 0, value);
		ret = kstrtouint(workarea, 16, value);
		if (ret)
		return ret;
		return -EIO;

		return len;
		}