Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f3af89d1 authored by Johannes Berg's avatar Johannes Berg Committed by John W. Linville
Browse files

mac80211: fix debugfs_sta print_mac() warning 



When print_mac() was marked as __pure to avoid emitting a function
call in pr_debug() scenarios, a warning in this code surfaced since
it relies on the fact that the buffer is modified and doesn't use
the return value. This patch makes it use the return value instead.

Signed-off-by: default avatarJohannes Berg <johannes@sipsolutions.net>
Reported-by: default avatarHarvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 665e8aaf

net/mac80211/debugfs_sta.c

+3 −2
Original line number Original line Diff line number Diff line
@@ -297,12 +297,13 @@ STA_OPS_WR(agg_status); 
void ieee80211_sta_debugfs_add(struct sta_info *sta)

void ieee80211_sta_debugfs_add(struct sta_info *sta)

{

{

	struct dentry *stations_dir = sta->local->debugfs.stations;

	struct dentry *stations_dir = sta->local->debugfs.stations;

	DECLARE_MAC_BUF(mac);

	DECLARE_MAC_BUF(mbuf);

	u8 *mac;





	if (!stations_dir)

	if (!stations_dir)

		return;

		return;





	print_mac(mac, sta->addr);

	mac = print_mac(mbuf, sta->addr);





	sta->debugfs.dir = debugfs_create_dir(mac, stations_dir);

	sta->debugfs.dir = debugfs_create_dir(mac, stations_dir);

	if (!sta->debugfs.dir)

	if (!sta->debugfs.dir)