Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f1545154 authored by Tejun Heo's avatar Tejun Heo Committed by Jeff Garzik
Browse files

libata: quickly trigger SATA SPD down after debouncing failed 



Debouncing failure is a good indicator of basic link problem.  Use
-EPIPE to indicate debouncing failure and make ata_eh_reset() invoke
sata_down_spd_limit() if the error occurs during reset.

Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 008a7896

drivers/ata/libata-core.c

+4 −2
Original line number Diff line number Diff line
@@ -3267,9 +3267,11 @@ int sata_phy_debounce(struct ata_port *ap, const unsigned long *params, 
		last = cur;

		last_jiffies = jiffies;



		/* check deadline */

		/* Check deadline.  If debouncing failed, return

		 * -EPIPE to tell upper layer to lower link speed.

		 */

		if (time_after(jiffies, deadline))

			return -EBUSY;

			return -EPIPE;

	}

}

drivers/ata/libata-eh.c

+1 −1
Original line number Diff line number Diff line
@@ -1790,7 +1790,7 @@ static int ata_eh_reset(struct ata_port *ap, int classify, 
			schedule_timeout_uninterruptible(delta);

		}



		if (reset == hardreset &&

		if (rc == -EPIPE ||

		    try == ARRAY_SIZE(ata_eh_reset_timeouts) - 1)

			sata_down_spd_limit(ap);

		if (hardreset)