Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f0c1e460 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

serial: tegra: clean up tty-flag assignments 



The tty break and error flags are not bit masks so do not to use bitwise
OR when assigning them.

Note that there is no functional change due to the if-else construct and
flag having been initialised to zero (TTY_NORMAL).

Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cb8ee9f0

drivers/tty/serial/serial-tegra.c

+3 −3
Original line number Diff line number Diff line
@@ -319,16 +319,16 @@ static char tegra_uart_decode_rx_error(struct tegra_uart_port *tup, 
	if (unlikely(lsr & TEGRA_UART_LSR_ANY)) {

		if (lsr & UART_LSR_OE) {

			/* Overrrun error */

			flag |= TTY_OVERRUN;

			flag = TTY_OVERRUN;

			tup->uport.icount.overrun++;

			dev_err(tup->uport.dev, "Got overrun errors\n");

		} else if (lsr & UART_LSR_PE) {

			/* Parity error */

			flag |= TTY_PARITY;

			flag = TTY_PARITY;

			tup->uport.icount.parity++;

			dev_err(tup->uport.dev, "Got Parity errors\n");

		} else if (lsr & UART_LSR_FE) {

			flag |= TTY_FRAME;

			flag = TTY_FRAME;

			tup->uport.icount.frame++;

			dev_err(tup->uport.dev, "Got frame errors\n");

		} else if (lsr & UART_LSR_BI) {