Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f05ac2e5 authored by Yaniv Gardi's avatar Yaniv Gardi Committed by Martin K. Petersen
Browse files

scsi: ufs: avoid exception event handler racing with PM callbacks 



If device raises the exception event in the response to the commands
sent during the runtime/system PM callbacks, exception event handler
might run in parallel with PM callbacks and may see unclocked register
accesses. This change fixes this issue by not scheduling the exception
event handler while PM callbacks are running.

Reviewed-by: default avatarGilad Broner <gbroner@codeaurora.org>
Reviewed-by: default avatarDolev Raviv <draviv@codeaurora.org>
Signed-off-by: default avatarSubhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: default avatarYaniv Gardi <ygardi@codeaurora.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent e5ad406c

drivers/scsi/ufs/ufshcd.c

+14 −1
Original line number Diff line number Diff line
@@ -3144,7 +3144,20 @@ ufshcd_transfer_rsp_status(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) 
			scsi_status = result & MASK_SCSI_STATUS;

			result = ufshcd_scsi_cmd_status(lrbp, scsi_status);



			if (ufshcd_is_exception_event(lrbp->ucd_rsp_ptr))

			/*

			 * Currently we are only supporting BKOPs exception

			 * events hence we can ignore BKOPs exception event

			 * during power management callbacks. BKOPs exception

			 * event is not expected to be raised in runtime suspend

			 * callback as it allows the urgent bkops.

			 * During system suspend, we are anyway forcefully

			 * disabling the bkops and if urgent bkops is needed

			 * it will be enabled on system resume. Long term

			 * solution could be to abort the system suspend if

			 * UFS device needs urgent BKOPs.

			 */

			if (!hba->pm_op_in_progress &&

			    ufshcd_is_exception_event(lrbp->ucd_rsp_ptr))

				schedule_work(&hba->eeh_work);

			break;

		case UPIU_TRANSACTION_REJECT_UPIU: