Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f002a243 authored by Nicholas Bellinger's avatar Nicholas Bellinger
Browse files

target/file: Bump FD_MAX_SECTORS to 2048 to handle 1M sized I/Os



This patch bumps the default FILEIO backend FD_MAX_SECTORS value from
1024 -> 2048 in order to allow block_size=512 to handle 1M sized I/Os.

The current default rejects I/Os larger than 512K in sbc_parse_cdb():

[12015.915146] SCSI OP 2ah with too big sectors 1347 exceeds backend
hw_max_sectors: 1024
[12015.977744] SCSI OP 2ah with too big sectors 2048 exceeds backend
hw_max_sectors: 1024

This issue is present in >= v3.5 based kernels, introduced after the
removal of se_task logic.

Reported-by: default avatarViljami Ilola <azmulx@netikka.fi>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 72c77539
Loading
Loading
Loading
Loading
+1 −1
Original line number Original line Diff line number Diff line
@@ -7,7 +7,7 @@
#define FD_DEVICE_QUEUE_DEPTH	32
#define FD_DEVICE_QUEUE_DEPTH	32
#define FD_MAX_DEVICE_QUEUE_DEPTH 128
#define FD_MAX_DEVICE_QUEUE_DEPTH 128
#define FD_BLOCKSIZE		512
#define FD_BLOCKSIZE		512
#define FD_MAX_SECTORS		1024
#define FD_MAX_SECTORS		2048


#define RRF_EMULATE_CDB		0x01
#define RRF_EMULATE_CDB		0x01
#define RRF_GOT_LBA		0x02
#define RRF_GOT_LBA		0x02