Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit efaffb78 authored by Li Zefan's avatar Li Zefan Committed by David S. Miller
Browse files

net: appletalk: use seq_hlist_foo() helpers 



Simplify seq_file code.

Signed-off-by: default avatarLi Zefan <lizf@cn.fujitsu.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b512f3d8

net/appletalk/atalk_proc.c

+3 −27
Original line number Diff line number Diff line
@@ -144,40 +144,16 @@ static int atalk_seq_route_show(struct seq_file *seq, void *v) 
	return 0;

}



static __inline__ struct sock *atalk_get_socket_idx(loff_t pos)

{

	struct sock *s;

	struct hlist_node *node;



	sk_for_each(s, node, &atalk_sockets)

		if (!pos--)

			goto found;

	s = NULL;

found:

	return s;

}



static void *atalk_seq_socket_start(struct seq_file *seq, loff_t *pos)

	__acquires(atalk_sockets_lock)

{

	loff_t l = *pos;



	read_lock_bh(&atalk_sockets_lock);

	return l ? atalk_get_socket_idx(--l) : SEQ_START_TOKEN;

	return seq_hlist_start_head(&atalk_sockets, *pos);

}



static void *atalk_seq_socket_next(struct seq_file *seq, void *v, loff_t *pos)

{

	struct sock *i;



	++*pos;

	if (v == SEQ_START_TOKEN) {

		i = sk_head(&atalk_sockets);

		goto out;

	}

	i = sk_next(v);

out:

	return i;

	return seq_hlist_next(v, &atalk_sockets, pos);

}



static void atalk_seq_socket_stop(struct seq_file *seq, void *v)
@@ -197,7 +173,7 @@ static int atalk_seq_socket_show(struct seq_file *seq, void *v) 
		goto out;

	}



	s = v;

	s = sk_entry(v);

	at = at_sk(s);



	seq_printf(seq, "%02X   %04X:%02X:%02X  %04X:%02X:%02X  %08X:%08X "