Commit ef96fddd authored Oct 08, 2014 by Tapasweni Pathak Committed by Greg Kroah-Hartman Oct 20, 2014

staging: lustre: lustre: llite: use DIV_ROUND_UP



The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /
(d)) but is perhaps more readable.

Coccinelle script used :

// <smpl>
@haskernel@
@@
@depends on haskernel@
expression n,d;
@@
(
- (n + d - 1) / d
+ DIV_ROUND_UP(n,d)
|
- (n + (d - 1)) / d
+ DIV_ROUND_UP(n,d)
)
@depends on haskernel@
expression n,d;
@@
- DIV_ROUND_UP((n),d)
+ DIV_ROUND_UP(n,d)
@depends on haskernel@
expression n,d;
@@
- DIV_ROUND_UP(n,(d))
+ DIV_ROUND_UP(n,d)
// </smpl>

Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent a15dbf99

drivers/staging/lustre/lustre/llite/rw26.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -417,7 +417,7 @@ static ssize_t ll_direct_IO_26(int rw, struct kiocb *iocb,

		result = iov_iter_get_pages_alloc(iter, &pages, count, &offs);
		if (likely(result > 0)) {
		int n = (result + offs + PAGE_SIZE - 1) / PAGE_SIZE;
		int n = DIV_ROUND_UP(result + offs, PAGE_SIZE);
		result = ll_direct_IO_26_seg(env, io, rw, inode,
		file->f_mapping,
		result, file_offset,