Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ef283688 authored by Kees Cook's avatar Kees Cook Committed by Martin Schwidefsky
Browse files

s390: avoid format strings leaking into names 



This makes sure format strings can't accidentally leak into kernel
interface names.

Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent 0eb69a0c

drivers/s390/block/dcssblk.c

+1 −1
Original line number Diff line number Diff line
@@ -593,7 +593,7 @@ dcssblk_add_store(struct device *dev, struct device_attribute *attr, const char 
	dev_info->start = dcssblk_find_lowest_addr(dev_info);

	dev_info->end = dcssblk_find_highest_addr(dev_info);



	dev_set_name(&dev_info->dev, dev_info->segment_name);

	dev_set_name(&dev_info->dev, "%s", dev_info->segment_name);

	dev_info->dev.release = dcssblk_release_segment;

	dev_info->dev.groups = dcssblk_dev_attr_groups;

	INIT_LIST_HEAD(&dev_info->lh);

drivers/s390/char/vmlogrdr.c

+1 −1
Original line number Diff line number Diff line
@@ -761,7 +761,7 @@ static int vmlogrdr_register_device(struct vmlogrdr_priv_t *priv) 


	dev = kzalloc(sizeof(struct device), GFP_KERNEL);

	if (dev) {

		dev_set_name(dev, priv->internal_name);

		dev_set_name(dev, "%s", priv->internal_name);

		dev->bus = &iucv_bus;

		dev->parent = iucv_root;

		dev->driver = &vmlogrdr_driver;

drivers/s390/crypto/zcrypt_api.c

+1 −1
Original line number Diff line number Diff line
@@ -356,7 +356,7 @@ struct zcrypt_ops *zcrypt_msgtype_request(unsigned char *name, int variant) 


	zops = __ops_lookup(name, variant);

	if (!zops) {

		request_module(name);

		request_module("%s", name);

		zops = __ops_lookup(name, variant);

	}

	if ((!zops) || (!try_module_get(zops->owner)))