Commit eda94710 authored Oct 27, 2012 by Mauro Carvalho Chehab

[media] pwc-if: must check vb2_queue_init() success

drivers/media/usb/pwc/pwc-if.c: In function 'usb_pwc_probe':
drivers/media/usb/pwc/pwc-if.c:1003:16: warning: ignoring return value of 'vb2_queue_init', declared with attribute warn_unused_result [-Wunused-result]
In the past, it used to have a logic there at queue init that would
BUG() on errors. This logic got removed. Drivers are now required
to explicitly handle the queue initialization errors, or very bad
things may happen.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 0dc6eb9f

drivers/media/usb/pwc/pwc-if.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -1000,7 +1000,11 @@ static int usb_pwc_probe(struct usb_interface *intf, const struct usb_device_id
		pdev->vb_queue.buf_struct_size = sizeof(struct pwc_frame_buf);
		pdev->vb_queue.ops = &pwc_vb_queue_ops;
		pdev->vb_queue.mem_ops = &vb2_vmalloc_memops;
		vb2_queue_init(&pdev->vb_queue);
		rc = vb2_queue_init(&pdev->vb_queue);
		if (rc < 0) {
		PWC_ERROR("Oops, could not initialize vb2 queue.\n");
		goto err_free_mem;
		}

		/* Init video_device structure */
		memcpy(&pdev->vdev, &pwc_template, sizeof(pwc_template));