Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ed4ec814 authored by Jean Delvare's avatar Jean Delvare Committed by Mark M. Hoffman
Browse files

hwmon: (adt7473) Initialize max_duty_at_overheat before use 



data->max_duty_at_overheat is not updated in adt7473_update_device,
so it might be used before it is initialized (if the user reads from
sysfs file max_duty_at_crit before writing to it.)

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Acked-by: default avatarDarrick J. Wong <djwong@us.ibm.com>
Signed-off-by: default avatarMark M. Hoffman <mhoffman@lightlink.com>
parent d38b1497

drivers/hwmon/adt7473.c

+3 −0
Original line number Diff line number Diff line
@@ -309,6 +309,9 @@ static struct adt7473_data *adt7473_update_device(struct device *dev) 
						ADT7473_REG_PWM_BHVR(i));

	}



	i = i2c_smbus_read_byte_data(client, ADT7473_REG_CFG4);

	data->max_duty_at_overheat = !!(i & ADT7473_CFG4_MAX_DUTY_AT_OVT);



	data->limits_last_updated = local_jiffies;

	data->limits_valid = 1;