Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ed023d52 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: amplc_dio200_common: remove unnecessary 'counter_number' checks 



The 'counter_number' in these functions is the comedi channel number from the
chanspec. The comedi core validates the chanspec before calling the driver
functions. Remove the unnecessary checks.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fdb7c3ec

drivers/staging/comedi/drivers/amplc_dio200_common.c

+0 −8
Original line number Diff line number Diff line
@@ -577,8 +577,6 @@ static int dio200_subdev_8254_set_gate_src(struct comedi_device *dev, 


	if (!board->has_clk_gat_sce)

		return -1;

	if (counter_number > 2)

		return -1;

	if (gate_src > (board->is_pcie ? 31 : 7))

		return -1;
@@ -598,8 +596,6 @@ static int dio200_subdev_8254_get_gate_src(struct comedi_device *dev, 


	if (!board->has_clk_gat_sce)

		return -1;

	if (counter_number > 2)

		return -1;



	return subpriv->gate_src[counter_number];

}
@@ -615,8 +611,6 @@ static int dio200_subdev_8254_set_clock_src(struct comedi_device *dev, 


	if (!board->has_clk_gat_sce)

		return -1;

	if (counter_number > 2)

		return -1;

	if (clock_src > (board->is_pcie ? 31 : 7))

		return -1;
@@ -638,8 +632,6 @@ static int dio200_subdev_8254_get_clock_src(struct comedi_device *dev, 


	if (!board->has_clk_gat_sce)

		return -1;

	if (counter_number > 2)

		return -1;



	clock_src = subpriv->clock_src[counter_number];

	*period_ns = clock_period[clock_src];