Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ecee51b7 authored by Heiko Carstens's avatar Heiko Carstens Committed by Jeff Garzik
Browse files

qeth: dont return the return values of void functions. 



Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: default avatarUrsula Braun <braunu@de.ibm.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent cde46035

drivers/s390/net/qeth.h

+2 −2
Original line number Original line Diff line number Diff line
@@ -1178,9 +1178,9 @@ qeth_ipaddr_to_string(enum qeth_prot_versions proto, const __u8 *addr, 
		      char *buf)

		      char *buf)

{

{

	if (proto == QETH_PROT_IPV4)

	if (proto == QETH_PROT_IPV4)

		return qeth_ipaddr4_to_string(addr, buf);

		qeth_ipaddr4_to_string(addr, buf);

	else if (proto == QETH_PROT_IPV6)

	else if (proto == QETH_PROT_IPV6)

		return qeth_ipaddr6_to_string(addr, buf);

		qeth_ipaddr6_to_string(addr, buf);

}

}





static inline int

static inline int

drivers/s390/net/qeth_sys.c

+4 −4
Original line number Original line Diff line number Diff line
@@ -1760,10 +1760,10 @@ qeth_remove_device_attributes(struct device *dev) 
{

{

	struct qeth_card *card = dev->driver_data;

	struct qeth_card *card = dev->driver_data;





	if (card->info.type == QETH_CARD_TYPE_OSN)

	if (card->info.type == QETH_CARD_TYPE_OSN) {

		return sysfs_remove_group(&dev->kobj,

		sysfs_remove_group(&dev->kobj, &qeth_osn_device_attr_group);

					  &qeth_osn_device_attr_group);

		return;



	}

	sysfs_remove_group(&dev->kobj, &qeth_device_attr_group);

	sysfs_remove_group(&dev->kobj, &qeth_device_attr_group);

	sysfs_remove_group(&dev->kobj, &qeth_device_ipato_group);

	sysfs_remove_group(&dev->kobj, &qeth_device_ipato_group);

	sysfs_remove_group(&dev->kobj, &qeth_device_vipa_group);

	sysfs_remove_group(&dev->kobj, &qeth_device_vipa_group);