Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ecc8fb11 authored by Amir Vadai's avatar Amir Vadai Committed by David S. Miller
Browse files

net/mlx4_core: Deprecate use_prio module parameter 



use_prio was added as part of an infrastructure for running FCoE in A0 mode.
FCoE didn't get into Mellanox Upstream driver, and when it will, it won't be
using A0 steering mode.

Therefore we can safely deprecate this module parameter without hurting any
existing user.

CC: Carol Soto <clsoto@linux.vnet.ibm.com>
Signed-off-by: default avatarAmir Vadai <amirv@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 65db611a

drivers/net/ethernet/mellanox/mlx4/main.c

+4 −4
Original line number Original line Diff line number Diff line
@@ -132,8 +132,7 @@ MODULE_PARM_DESC(log_num_vlan, "Log2 max number of VLANs per ETH port (0-7)"); 




static bool use_prio;

static bool use_prio;

module_param_named(use_prio, use_prio, bool, 0444);

module_param_named(use_prio, use_prio, bool, 0444);

MODULE_PARM_DESC(use_prio, "Enable steering by VLAN priority on ETH ports "

MODULE_PARM_DESC(use_prio, "Enable steering by VLAN priority on ETH ports (deprecated)");

		  "(0/1, default 0)");





int log_mtts_per_seg = ilog2(MLX4_MTT_ENTRY_PER_SEG);

int log_mtts_per_seg = ilog2(MLX4_MTT_ENTRY_PER_SEG);

module_param_named(log_mtts_per_seg, log_mtts_per_seg, int, 0444);

module_param_named(log_mtts_per_seg, log_mtts_per_seg, int, 0444);
@@ -290,7 +289,6 @@ static int mlx4_dev_cap(struct mlx4_dev *dev, struct mlx4_dev_cap *dev_cap) 




	dev->caps.log_num_macs  = log_num_mac;

	dev->caps.log_num_macs  = log_num_mac;

	dev->caps.log_num_vlans = MLX4_LOG_NUM_VLANS;

	dev->caps.log_num_vlans = MLX4_LOG_NUM_VLANS;

	dev->caps.log_num_prios = use_prio ? 3 : 0;





	for (i = 1; i <= dev->caps.num_ports; ++i) {

	for (i = 1; i <= dev->caps.num_ports; ++i) {

		dev->caps.port_type[i] = MLX4_PORT_TYPE_NONE;

		dev->caps.port_type[i] = MLX4_PORT_TYPE_NONE;
@@ -358,7 +356,6 @@ static int mlx4_dev_cap(struct mlx4_dev *dev, struct mlx4_dev_cap *dev_cap) 
		dev->caps.reserved_qps_cnt[MLX4_QP_REGION_FC_ADDR] =

		dev->caps.reserved_qps_cnt[MLX4_QP_REGION_FC_ADDR] =

		(1 << dev->caps.log_num_macs) *

		(1 << dev->caps.log_num_macs) *

		(1 << dev->caps.log_num_vlans) *

		(1 << dev->caps.log_num_vlans) *

		(1 << dev->caps.log_num_prios) *

		dev->caps.num_ports;

		dev->caps.num_ports;

	dev->caps.reserved_qps_cnt[MLX4_QP_REGION_FC_EXCH] = MLX4_NUM_FEXCH;

	dev->caps.reserved_qps_cnt[MLX4_QP_REGION_FC_EXCH] = MLX4_NUM_FEXCH;
@@ -2775,6 +2772,9 @@ static int __init mlx4_verify_params(void) 
		pr_warning("mlx4_core: log_num_vlan - obsolete module param, using %d\n",

		pr_warning("mlx4_core: log_num_vlan - obsolete module param, using %d\n",

			   MLX4_LOG_NUM_VLANS);

			   MLX4_LOG_NUM_VLANS);





	if (use_prio != 0)

		pr_warn("mlx4_core: use_prio - obsolete module param, ignored\n");



	if ((log_mtts_per_seg < 1) || (log_mtts_per_seg > 7)) {

	if ((log_mtts_per_seg < 1) || (log_mtts_per_seg > 7)) {

		pr_warning("mlx4_core: bad log_mtts_per_seg: %d\n", log_mtts_per_seg);

		pr_warning("mlx4_core: bad log_mtts_per_seg: %d\n", log_mtts_per_seg);

		return -1;

		return -1;

include/linux/mlx4/device.h

+0 −1
Original line number Original line Diff line number Diff line
@@ -449,7 +449,6 @@ struct mlx4_caps { 
	int                     reserved_qps_base[MLX4_NUM_QP_REGION];

	int                     reserved_qps_base[MLX4_NUM_QP_REGION];

	int                     log_num_macs;

	int                     log_num_macs;

	int                     log_num_vlans;

	int                     log_num_vlans;

	int                     log_num_prios;

	enum mlx4_port_type	port_type[MLX4_MAX_PORTS + 1];

	enum mlx4_port_type	port_type[MLX4_MAX_PORTS + 1];

	u8			supported_type[MLX4_MAX_PORTS + 1];

	u8			supported_type[MLX4_MAX_PORTS + 1];

	u8                      suggested_type[MLX4_MAX_PORTS + 1];

	u8                      suggested_type[MLX4_MAX_PORTS + 1];