Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eca7370b authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Paul Mundt
Browse files

sm501fb: use display information in info not in var for panning 



We must not use any information in the passed var besides xoffset,
yoffset and vmode as otherwise applications might abuse it.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Ben Dooks <ben@simtec.co.uk>
Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
parent 1388f6a7

drivers/video/sm501fb.c

+3 −3
Original line number Diff line number Diff line
@@ -582,7 +582,7 @@ static int sm501fb_pan_crt(struct fb_var_screeninfo *var, 
{

	struct sm501fb_par  *par = info->par;

	struct sm501fb_info *fbi = par->info;

	unsigned int bytes_pixel = var->bits_per_pixel / 8;

	unsigned int bytes_pixel = info->var.bits_per_pixel / 8;

	unsigned long reg;

	unsigned long xoffs;
@@ -614,10 +614,10 @@ static int sm501fb_pan_pnl(struct fb_var_screeninfo *var, 
	struct sm501fb_info *fbi = par->info;

	unsigned long reg;



	reg = var->xoffset | (var->xres_virtual << 16);

	reg = var->xoffset | (info->var.xres_virtual << 16);

	smc501_writel(reg, fbi->regs + SM501_DC_PANEL_FB_WIDTH);



	reg = var->yoffset | (var->yres_virtual << 16);

	reg = var->yoffset | (info->var.yres_virtual << 16);

	smc501_writel(reg, fbi->regs + SM501_DC_PANEL_FB_HEIGHT);



	sm501fb_sync_regs(fbi);