Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ebca4f1b authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Jesse Barnes
Browse files

PCI: fix reference leak in pci_get_dev_by_id() 



Alex Chiang and Matthew Wilcox pointed out that pci_get_dev_by_id() does
not properly decrement the reference on the from pointer if it is
present, like the documentation for the function states it will.

It fixes a pretty bad leak in the hotplug core (we were leaking an
entire struct pci_dev for each function of each offlined card, the first
time around; subsequent onlines/offlines were ok).

Cc: Matthew Wilcox <matthew@wil.cx>
Cc: stable <stable@kernel.org>
Tested-by: default avatarAlex Chiang <achiang@hp.com>
Acked-by: default avatarAlex Chiang <achiang@hp.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
parent d6a9e9b4

drivers/pci/search.c

+2 −0
Original line number Diff line number Diff line
@@ -280,6 +280,8 @@ static struct pci_dev *pci_get_dev_by_id(const struct pci_device_id *id, 
			      match_pci_dev_by_id);

	if (dev)

		pdev = to_pci_dev(dev);

	if (from)

		pci_dev_put(from);

	return pdev;

}