Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eaeee242 authored by Artem Bityutskiy's avatar Artem Bityutskiy
Browse files

UBIFS: fix a rare memory leak in ro to rw remounting path 



When re-mounting from R/O mode to R/W mode and the LEB count in the superblock
is not up-to date, because for the underlying UBI volume became larger, we
re-write the superblock. We allocate RAM for these purposes, but never free it.
So this is a memory leak, although very rare one.

Signed-off-by: default avatarArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
Cc: stable@kernel.org
parent c1f1f91d

fs/ubifs/sb.c

+2 −1
Original line number Diff line number Diff line
@@ -475,7 +475,8 @@ static int validate_sb(struct ubifs_info *c, struct ubifs_sb_node *sup) 
 * @c: UBIFS file-system description object

 *

 * This function returns a pointer to the superblock node or a negative error

 * code.

 * code. Note, the user of this function is responsible of kfree()'ing the

 * returned superblock buffer.

 */

struct ubifs_sb_node *ubifs_read_sb_node(struct ubifs_info *c)

{

fs/ubifs/super.c

+1 −0
Original line number Diff line number Diff line
@@ -1585,6 +1585,7 @@ static int ubifs_remount_rw(struct ubifs_info *c) 
		}

		sup->leb_cnt = cpu_to_le32(c->leb_cnt);

		err = ubifs_write_sb_node(c, sup);

		kfree(sup);

		if (err)

			goto out;

	}