Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ea9dd9d6 authored by Chanwoo Choi's avatar Chanwoo Choi Committed by Greg Kroah-Hartman
Browse files

extcon: Change permission 'state' sysfs entry (rw -> r) 



This patch change permission from read/write to only read.
The specific process in the user-space couldn't change the state
of cable when cable is attached or detached.
- /sys/class/extcon/[devine name]/state

Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: default avatarMyungjoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 12e50c30

drivers/extcon/extcon-class.c

+1 −22
Original line number Original line Diff line number Diff line
@@ -185,26 +185,6 @@ static ssize_t cable_state_show(struct device *dev, 
					       cable->cable_index));

					       cable->cable_index));

}

}





static ssize_t cable_state_store(struct device *dev,

				 struct device_attribute *attr, const char *buf,

				 size_t count)

{

	struct extcon_cable *cable = container_of(attr, struct extcon_cable,

						  attr_state);

	int ret, state;



	ret = sscanf(buf, "%d", &state);

	if (ret == 0)

		ret = -EINVAL;

	else

		ret = extcon_set_cable_state_(cable->edev, cable->cable_index,

					      state);



	if (ret < 0)

		return ret;

	return count;

}



/**

/**

 * extcon_update_state() - Update the cable attach states of the extcon device

 * extcon_update_state() - Update the cable attach states of the extcon device

 *			only for the masked bits.

 *			only for the masked bits.
@@ -665,9 +645,8 @@ int extcon_dev_register(struct extcon_dev *edev, struct device *dev) 




			sysfs_attr_init(&cable->attr_state.attr);

			sysfs_attr_init(&cable->attr_state.attr);

			cable->attr_state.attr.name = "state";

			cable->attr_state.attr.name = "state";

			cable->attr_state.attr.mode = 0644;

			cable->attr_state.attr.mode = 0444;

			cable->attr_state.show = cable_state_show;

			cable->attr_state.show = cable_state_show;

			cable->attr_state.store = cable_state_store;

		}

		}

	}

	}