Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ea6bb33e authored Nov 25, 2014 by Christoph Hellwig

fc: FCP_PTA_SIMPLE is 0



Not need to have an if/else to either assign FCP_PTA_SIMPLE or 0
to a variable.

Btw, it seems we really should factor generating a fcp cmnd from
a scsi_cmnd into a common helper.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>

parent e1c50738

drivers/scsi/bnx2fc/bnx2fc_io.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -1737,11 +1737,7 @@ void bnx2fc_build_fcp_cmnd(struct bnx2fc_cmd *io_req,
		fcp_cmnd->fc_pri_ta = 0;
		fcp_cmnd->fc_tm_flags = io_req->mp_req.tm_flags;
		fcp_cmnd->fc_flags = io_req->io_req_flags;

		if (sc_cmd->flags & SCMD_TAGGED)
		fcp_cmnd->fc_pri_ta = FCP_PTA_SIMPLE;
		else
		fcp_cmnd->fc_pri_ta = 0;
		}

		static void bnx2fc_parse_fcp_rsp(struct bnx2fc_cmd *io_req,

drivers/scsi/csiostor/csio_scsi.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -172,10 +172,7 @@ csio_scsi_fcp_cmnd(struct csio_ioreq req, void addr)
		fcp_cmnd->fc_cmdref = 0;

		memcpy(fcp_cmnd->fc_cdb, scmnd->cmnd, 16);
		if (scmnd->flags & SCMD_TAGGED)
		fcp_cmnd->fc_pri_ta = FCP_PTA_SIMPLE;
		else
		fcp_cmnd->fc_pri_ta = 0;
		fcp_cmnd->fc_dl = cpu_to_be32(scsi_bufflen(scmnd));

		if (req->nsge)