Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e9edd199 authored by Robert Baldyga's avatar Robert Baldyga Committed by Felipe Balbi
Browse files

usb: gadget: s3c-hsotg: fix set_ep_maxpacket function 



This patch fixes max packet size check in s3c_hsotg_set_ep_maxpacket()
function. According USB specification, bits 10..0 of mps specifies maximum
packet size, so there is bitwise AND between mps and 0x7ff value. Also added
check if maxpacket isn't grater than 1024 which is maximum size od single USB
transaction.

In s3c_hsotg_ep_enable() function added s3c_hsotg_set_ep_maxpacket() call
instead of setting ep.maxpacket value directly.

Signed-off-by: default avatarRobert Baldyga <r.baldyga@samsung.com>
Signed-off-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent dc807576

drivers/usb/gadget/s3c-hsotg.c

+5 −6
Original line number Diff line number Diff line
@@ -1705,15 +1705,14 @@ static void s3c_hsotg_set_ep_maxpacket(struct s3c_hsotg *hsotg, 
		mpsval = s3c_hsotg_ep0_mps(mps);

		if (mpsval > 3)

			goto bad_mps;

		hs_ep->ep.maxpacket = mps;

	} else {

		if (mps >= DxEPCTL_MPS_LIMIT+1)

		mpsval = mps & DxEPCTL_MPS_MASK;

		if (mpsval > 1024)

			goto bad_mps;



		mpsval = mps;

		hs_ep->ep.maxpacket = mpsval;

	}



	hs_ep->ep.maxpacket = mps;



	/*

	 * update both the in and out endpoint controldir_ registers, even

	 * if one of the directions may not be in use.
@@ -2579,7 +2578,7 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep, 
	epctrl |= DxEPCTL_SNAK;



	/* update the endpoint state */

	hs_ep->ep.maxpacket = mps;

	s3c_hsotg_set_ep_maxpacket(hsotg, hs_ep->index, mps);



	/* default, set to non-periodic */

	hs_ep->periodic = 0;