Commit e9db5c21 authored Dec 17, 2013 by Wenliang Fan Committed by David S. Miller Dec 19, 2013

drivers/net/hamradio: Integer overflow in hdlcdrv_ioctl()



The local variable 'bi' comes from userspace. If userspace passed a
large number to 'bi.data.calibrate', there would be an integer overflow
in the following line:
	s->hdlctx.calibrate = bi.data.calibrate * s->par.bitrate / 16;

Signed-off-by: Wenliang Fan <fanwlexca@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0c8d087c

drivers/net/hamradio/hdlcdrv.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -571,6 +571,8 @@ static int hdlcdrv_ioctl(struct net_device dev, struct ifreq ifr, int cmd)
		case HDLCDRVCTL_CALIBRATE:
		if(!capable(CAP_SYS_RAWIO))
		return -EPERM;
		if (bi.data.calibrate > INT_MAX / s->par.bitrate)
		return -EINVAL;
		s->hdlctx.calibrate = bi.data.calibrate * s->par.bitrate / 16;
		return 0;