Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e985dbf7 authored by Sylwester Nawrocki's avatar Sylwester Nawrocki Committed by Mauro Carvalho Chehab
Browse files

[media] s5p-fimc: Fix locking in subdev set_crop op 



When setting TRY crop on the sub-device the mutex was erroneously acquired
rather than released on exit path. This bug is present in kernels starting
from v3.2.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 910a5f2e

drivers/media/video/s5p-fimc/fimc-capture.c

+1 −1
Original line number Diff line number Diff line
@@ -1383,7 +1383,7 @@ static int fimc_subdev_set_crop(struct v4l2_subdev *sd, 
	fimc_capture_try_crop(ctx, r, crop->pad);



	if (crop->which == V4L2_SUBDEV_FORMAT_TRY) {

		mutex_lock(&fimc->lock);

		mutex_unlock(&fimc->lock);

		*v4l2_subdev_get_try_crop(fh, crop->pad) = *r;

		return 0;

	}