Commit e944ec2c authored Apr 29, 2015 by Namhyung Kim Committed by Arnaldo Carvalho de Melo May 01, 2015

perf report: Fix -T/--threads option to work again



The commit 512ae1bd ("perf tools: Consolidate management of default
sort orders") changed default value of the 'sort_order' variable to NULL
indicating that users don't set any sort keys on the command line.

However it missed to update a check in perf_evlist__tty_browse_hists()
so that 'perf report -T' cannot show the per-thread values after the
normal output.  This patch fixes it to work again.

Note that the -T option only works on --stdio and neither --sort nor
--parent option was given.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1430309328-28317-1-git-send-email-namhyung@kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 8cc67c3b

tools/perf/builtin-report.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -329,7 +329,7 @@ static int perf_evlist__tty_browse_hists(struct perf_evlist *evlist,
	fprintf(stdout, "\n\n");		fprintf(stdout, "\n\n");
	}		}

	if (sort_order == default_sort_order &&		if (sort_order == NULL &&
	parent_pattern == default_parent_pattern) {		parent_pattern == default_parent_pattern) {
	fprintf(stdout, "#\n# (%s)\n#\n", help);		fprintf(stdout, "#\n# (%s)\n#\n", help);