Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e89dafb5 authored by Michael Ellerman's avatar Michael Ellerman
Browse files

powerpc: Only do dynamic DMA zone limits on platforms that need it 



Scott's patch 1c98025c "Dynamic DMA zone limits" changed
dma_direct_alloc_coherent() to start using dev->coherent_dma_mask.

That seems fair enough, but it exposes the fact that some of the drivers
we care about on IBM platforms aren't setting the coherent mask.

The proper fix is to have drivers set the coherent mask and also have
the platform code honor it.

For now, just restrict the dynamic DMA zone limits to the platforms that
need it.

Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Acked-by: default avatarScott Wood <scottwood@freescale.com>
parent 86be175a

arch/powerpc/kernel/dma.c

+8 −0
Original line number Diff line number Diff line
@@ -53,9 +53,16 @@ void *dma_direct_alloc_coherent(struct device *dev, size_t size, 
#else

	struct page *page;

	int node = dev_to_node(dev);

#ifdef CONFIG_FSL_SOC

	u64 pfn = get_pfn_limit(dev);

	int zone;



	/*

	 * This code should be OK on other platforms, but we have drivers that

	 * don't set coherent_dma_mask. As a workaround we just ifdef it. This

	 * whole routine needs some serious cleanup.

	 */



	zone = dma_pfn_limit_to_zone(pfn);

	if (zone < 0) {

		dev_err(dev, "%s: No suitable zone for pfn %#llx\n",
@@ -73,6 +80,7 @@ void *dma_direct_alloc_coherent(struct device *dev, size_t size, 
		break;

#endif

	};

#endif /* CONFIG_FSL_SOC */



	/* ignore region specifiers */

	flag  &= ~(__GFP_HIGHMEM);