Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e83596b4 authored by David Daney's avatar David Daney Committed by Martin K. Petersen
Browse files

pm80xx: Remove bogus address masking in pm8001_ioremap() 



It is unclear what the original intent of the masking was, but it is
clearly incorrect to truncate a physical address before calling
ioremap().  On systems where there are valid physical address bits above
bit-31 (arm64 for example) the result is an eventual OOPs when
initializing the driver.

Remove the bogus code to fix it.

Signed-off-by: default avatarDavid Daney <david.daney@cavium.com>
Acked-by: default avatarJack Wang <jinpu.wang@profitbricks.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 5ea33eb5

drivers/scsi/pm8001/pm8001_init.c

+0 −2
Original line number Diff line number Diff line
@@ -418,8 +418,6 @@ static int pm8001_ioremap(struct pm8001_hba_info *pm8001_ha) 
		if (pci_resource_flags(pdev, bar) & IORESOURCE_MEM) {

			pm8001_ha->io_mem[logicalBar].membase =

				pci_resource_start(pdev, bar);

			pm8001_ha->io_mem[logicalBar].membase &=

				(u32)PCI_BASE_ADDRESS_MEM_MASK;

			pm8001_ha->io_mem[logicalBar].memsize =

				pci_resource_len(pdev, bar);

			pm8001_ha->io_mem[logicalBar].memvirtaddr =