Commit e7a33c4d authored Sep 15, 2016 by Markus Elfring Committed by Herbert Xu Sep 22, 2016

crypto: caam - Use kmalloc_array() in ahash_setkey()



* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 664f570a

drivers/crypto/caam/caamhash.c

+3 −2

Original line number	Original line	Diff line number	Diff line
	@@ -525,8 +525,9 @@ static int ahash_setkey(struct crypto_ahash *ahash,
	#endif		#endif

	if (keylen > blocksize) {		if (keylen > blocksize) {
	hashed_key = kmalloc(sizeof(u8) * digestsize, GFP_KERNEL \|		hashed_key = kmalloc_array(digestsize,
	GFP_DMA);		sizeof(*hashed_key),
			GFP_KERNEL \| GFP_DMA);
	if (!hashed_key)		if (!hashed_key)
	return -ENOMEM;		return -ENOMEM;
	ret = hash_digest_key(ctx, key, &keylen, hashed_key,		ret = hash_digest_key(ctx, key, &keylen, hashed_key,