Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e7222ca9 authored by Florin Malita's avatar Florin Malita Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (6350): V4L: possible leak in em28xx_init_isoc 



Coverity (CID 1929) spotted the following: if a transfer buffer
allocation fails, the last allocated urb is leaked (it hasn't been
stored in dev->urb[] yet so em28xx_uninit_isoc misses it). The patch
also includes a small typo fix.

Signed-off-by: default avatarFlorin Malita <fmalita@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
parent 2f7362ef

drivers/media/video/em28xx/em28xx-core.c

+2 −1
Original line number Diff line number Diff line
@@ -648,7 +648,7 @@ void em28xx_uninit_isoc(struct em28xx *dev) 
 */

int em28xx_init_isoc(struct em28xx *dev)

{

	/* change interface to 3 which allowes the biggest packet sizes */

	/* change interface to 3 which allows the biggest packet sizes */

	int i, errCode;

	const int sb_size = EM28XX_NUM_PACKETS * dev->max_pkt_size;
@@ -673,6 +673,7 @@ int em28xx_init_isoc(struct em28xx *dev) 
					("unable to allocate %i bytes for transfer buffer %i\n",

					 sb_size, i);

			em28xx_uninit_isoc(dev);

			usb_free_urb(urb);

			return -ENOMEM;

		}

		memset(dev->transfer_buffer[i], 0, sb_size);