Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e6b50c30 authored by Dan Carpenter's avatar Dan Carpenter Committed by James Bottomley
Browse files

[SCSI] be2iscsi: correct return value in mgmt_invalidate_icds() 



This function should return 0 on error.  Returning -1 would cause a
crash.

Also there is an extra space before the newline character and a missing
space between the "for" and the "mgmt_invalidate_icds".  I put the string
on one line.  The current version of checkpatch.pl complains that the
line is too long, but it makes grepping easier.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Reviewed-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent f4b87dee

drivers/scsi/be2iscsi/be_mgmt.c

+2 −3
Original line number Diff line number Diff line
@@ -167,10 +167,9 @@ unsigned char mgmt_invalidate_icds(struct beiscsi_hba *phba, 
				&nonemb_cmd.dma);

	if (nonemb_cmd.va == NULL) {

		SE_DEBUG(DBG_LVL_1,

			 "Failed to allocate memory for"

			 "mgmt_invalidate_icds \n");

			 "Failed to allocate memory for mgmt_invalidate_icds\n");

		spin_unlock(&ctrl->mbox_lock);

		return -1;

		return 0;

	}

	nonemb_cmd.size = sizeof(struct invalidate_commands_params_in);

	req = nonemb_cmd.va;