Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e6afea0b authored by Mugunthan V N's avatar Mugunthan V N Committed by David S. Miller
Browse files

drivers: net: cpsw: fix dual EMAC stall when connected to same switch 



In commit 629c9a8f (drivers: net: cpsw: Add
default vlan for dual emac case also), api cpsw_add_default_vlan() also
changes the port vlan which is required to seperate the ports which results
in the following behavior

In Dual EMAC mode, when both the Etnernet connected is connected to same
switch, it creates a loop in the switch and when a broadcast packet is
received it is forwarded to the other port which stalls the whole switch
and needs a reset/power cycle to the switch to recover. So intead of using
the api, add only the default VLAN entry in dual EMAC case.

Cc: Yegor Yefremov <yegorslists@googlemail.com>
Cc: Felipe Balbi <balbi@ti.com>
Signed-off-by: default avatarMugunthan V N <mugunthanvnm@ti.com>
Tested-by: default avatarYegor Yefremov <yegorslists@googlemail.com>
Tested-by: default avatarFelipe Balbi <balbi@ti.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7f082319

drivers/net/ethernet/ti/cpsw.c

+6 −1
Original line number Diff line number Diff line
@@ -1212,7 +1212,12 @@ static int cpsw_ndo_open(struct net_device *ndev) 
	for_each_slave(priv, cpsw_slave_open, priv);



	/* Add default VLAN */

	if (!priv->data.dual_emac)

		cpsw_add_default_vlan(priv);

	else

		cpsw_ale_add_vlan(priv->ale, priv->data.default_vlan,

				  ALE_ALL_PORTS << priv->host_port,

				  ALE_ALL_PORTS << priv->host_port, 0, 0);



	if (!cpsw_common_res_usage_state(priv)) {

		/* setup tx dma to fixed prio and zero offset */