Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e6a5fdf5 authored by David S. Miller's avatar David S. Miller
Browse files

[NIU]: Fix write past end of array in niu_pci_probe_sprom(). 



Noticed by Coverity checker and reported by Adrian Bunk.

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 65c88466

drivers/net/niu.c

+2 −2
Original line number Diff line number Diff line
@@ -6213,7 +6213,7 @@ static int __devinit niu_pci_probe_sprom(struct niu *np) 
	val = nr64(ESPC_MOD_STR_LEN);

	niudbg(PROBE, "SPROM: MOD_STR_LEN[%llu]\n",

	       (unsigned long long) val);

	if (val > 8 * 4)

	if (val >= 8 * 4)

		return -EINVAL;



	for (i = 0; i < val; i += 4) {
@@ -6229,7 +6229,7 @@ static int __devinit niu_pci_probe_sprom(struct niu *np) 
	val = nr64(ESPC_BD_MOD_STR_LEN);

	niudbg(PROBE, "SPROM: BD_MOD_STR_LEN[%llu]\n",

	       (unsigned long long) val);

	if (val > 4 * 4)

	if (val >= 4 * 4)

		return -EINVAL;



	for (i = 0; i < val; i += 4) {