Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e5f1b194 authored by Imre Deak's avatar Imre Deak Committed by Linus Torvalds
Browse files

omap_uwire: SPI_CPHA mode bugfix 



The omap_uwire controller driver handles SPI_CPHA incorrectly;
It should mean:

  CPHA=0 ... sample at leading edge of clock
  CPHA=1 ... sample at trailing edge of clock

This bug has been masked by inverse bugs in layered drivers;
and was uncovered by running some of them on non-OMAP hardware.

Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 81fc6323

drivers/spi/omap_uwire.c

+2 −2
Original line number Diff line number Diff line
@@ -358,11 +358,11 @@ static int uwire_setup_transfer(struct spi_device *spi, struct spi_transfer *t) 
	switch (spi->mode & (SPI_CPOL | SPI_CPHA)) {

	case SPI_MODE_0:

	case SPI_MODE_3:

		flags |= UWIRE_WRITE_RISING_EDGE | UWIRE_READ_FALLING_EDGE;

		flags |= UWIRE_WRITE_FALLING_EDGE | UWIRE_READ_RISING_EDGE;

		break;

	case SPI_MODE_1:

	case SPI_MODE_2:

		flags |= UWIRE_WRITE_FALLING_EDGE | UWIRE_READ_RISING_EDGE;

		flags |= UWIRE_WRITE_RISING_EDGE | UWIRE_READ_FALLING_EDGE;

		break;

	}